Fix ToC incorrect highlight and search input text overlap [WEB-9223]#37256
Open
StefonSimmons wants to merge 2 commits into
Open
Fix ToC incorrect highlight and search input text overlap [WEB-9223]#37256StefonSimmons wants to merge 2 commits into
StefonSimmons wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Two UI fixes reported on the docs site:
ToC incorrect highlight (Catalog page): The
site-regionshortcode renders region-gated headings inside adisplay:nonecontainer. BecausegetBoundingClientRect()returns all zeros for hidden elements, the scroll-spy treated those headings as always at the top of the page. This caused the hidden heading's parent to appear highlighted in the ToC regardless of scroll position. Fix:getHeaderTop()helper returnslocalOffset + 1for zero-sized elements so hidden headings never satisfy the scroll condition.Search input text overlap with "/" shortcut indicator: The
::afterkeyboard shortcut hint element overlaps long query text at certain viewport widths. Fix: addedpadding-right: 30pxto.ais-SearchBox-inputon both the search results page and the navbar search to keep text clear of the indicator.motivation: bug fix: WEB-9223
preview:
[ / ]) does not overlap long search inputMerge instructions
Merge readiness:
AI assistance
Claude Code assisted with root cause analysis and initial implementation.
Additional notes