Skip to content

Fix ToC incorrect highlight and search input text overlap [WEB-9223]#37256

Open
StefonSimmons wants to merge 2 commits into
masterfrom
stefon.simmons/web-9223
Open

Fix ToC incorrect highlight and search input text overlap [WEB-9223]#37256
StefonSimmons wants to merge 2 commits into
masterfrom
stefon.simmons/web-9223

Conversation

@StefonSimmons
Copy link
Copy Markdown
Contributor

@StefonSimmons StefonSimmons commented Jun 4, 2026

What does this PR do? What is the motivation?

Two UI fixes reported on the docs site:

  1. ToC incorrect highlight (Catalog page): The site-region shortcode renders region-gated headings inside a display:none container. Because getBoundingClientRect() returns all zeros for hidden elements, the scroll-spy treated those headings as always at the top of the page. This caused the hidden heading's parent to appear highlighted in the ToC regardless of scroll position. Fix: getHeaderTop() helper returns localOffset + 1 for zero-sized elements so hidden headings never satisfy the scroll condition.

  2. Search input text overlap with "/" shortcut indicator: The ::after keyboard shortcut hint element overlaps long query text at certain viewport widths. Fix: added padding-right: 30px to .ais-SearchBox-input on both the search results page and the navbar search to keep text clear of the indicator.

motivation: bug fix: WEB-9223

preview:

Merge instructions

Merge readiness:

  • Ready for merge

AI assistance

Claude Code assisted with root cause analysis and initial implementation.

Additional notes

@StefonSimmons StefonSimmons requested a review from a team as a code owner June 4, 2026 13:55
@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label Jun 4, 2026
@StefonSimmons StefonSimmons marked this pull request as draft June 4, 2026 14:22
@StefonSimmons StefonSimmons marked this pull request as ready for review June 4, 2026 15:59
@StefonSimmons StefonSimmons changed the title [WEB-9223] Fix ToC incorrect highlight and search input text overlap Fix ToC incorrect highlight and search input text overlap [WEB-9223] Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant